Use datetime functions from python standard lib #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Replaced the |
|
The CI now just fails on lxml build for 3.11. This will be resolved when #351 gets merged. |
Evidlo
force-pushed
the
dateutil_remove
branch
from
7560ee0 to
e2017d3
Compare
WIP sad update format
Evidlo
force-pushed
the
dateutil_remove
branch
from
e2017d3 to
1fbd64a
Compare
|
Thanks! It's always good to get rid of dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The date handling functionality in Python std lib has been improved in Python 3 so we can take advantage of it and remove dependency on
dateutilpackage.This PR simplifies time zone handling for the various entry and group time values and creates time zone aware values everywhere.
Note that the parse function fromdateutilsis replaced by.fromisoformat()function fromdatetimeclass. However, this would raise the required Python version to 3.7. I believe this should be fine since 3.7 is quite old version and all major currently supported LTS Linux distributions are already on Python >=3.7.If there is need to stay at Python 3.6, this can be rewritten in slightly more verbose way while still depending only on python standard library.Using the
strptimefunction now to stay compatible with Python 3.6 and to handle the time zone string .